search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.4k stars 1.26k forks source link

Repeated import of cover art from files #8991

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: uklotzde Date: 2017-12-03T13:53:13Z Status: Triaged Importance: Medium Launchpad Issue: lp1735996

Cover art for the same track might be requested from UI components like widgets in the library, the cover art display on the deck and the spinnies almost concurrently. The cover art cache accepts multiple requests for the same track from different requestores if the cover is not cached already, although all requests reference the same file. Why? Because the requestId contains both the requestor and the cover hash.

As a consequence multiple subsequent read operations for the same cover art image are performed. For embedded cover art this becomes obvious from the logs, because a SoundSourceProxy is created and embedded cover art is parsed repeatedly from the audio file, e.g. when loading a track into a deck.

Pending requests for the same cover hash need to be combined instead of creating new requests.

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2017-12-03T14:02:43Z

Should IMHO be fixed before releasing 2.1.0.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2017-12-03T20:20:48Z

The rejected PR for the cover hash might be related. https://github.com/mixxxdj/mixxx/pull/996

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2017-12-04T07:27:44Z

Both issues are unrelated, although targeting overlapping parts of the code.

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2017-12-07T23:45:27Z

I won't be able to complete this in time. It turned out that the caching and hashing needs to be changed to implement this properly. Maybe has more dependencies with https://github.com/mixxxdj/mixxx/pull/996 than expected.

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2017-12-28T04:57:56Z

Uwe or Daniel, would one of you like to assign yourself to take this up for 2.2?

mixxxbot commented 2 years ago

Commented by: rryan Date: 2018-09-20T18:11:11Z

Due to lack of progress, marking Triaged and clearing assignee. Feel free to revert if it is in fact still in progress :).