mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.37k stars 1.26k forks source link

Master out audio stutters during drag & drop #9004

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: Pegasus-RPG Date: 2017-12-13T15:59:34Z Status: Confirmed Importance: Critical Launchpad Issue: lp1738028


On Debian 8.9 with Mixxx git master r6402; built on: Dec  2 2017, 48kHz sample rate, ALSA back-end, master out set to a USB sound card, headphone out set to internal sound card, latency at 2.33ms, dragging and dropping tracks either to a crate or a deck causes the master out audio to stutter during the dragging. (I didn't check the headphone audio.)

Increasing the latency reduces the effect, but it's still present even at 21.3ms. It happens the same with just the master out set to the internal sound card and no headphone output set.

Even at 42.7ms, I still get occasional glitches on the master output dragging a track from the library to a crate or a deck.

I do see this problem in the latest 2.0/1.12 branch as well FWIW, so maybe it's just my system?

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2017-12-13T16:15:28Z


This usually indicates the latency is set too low. Where do you have it?

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2017-12-14T06:16:09Z


I also noticed the following warnings and audible pauses in the sound just today:

ALSA lib pcm.c:8323:(snd_pcm_recover) underrun occurred
Warning [Engine]: underflowHappened code: 6 
Warning [Engine]: underflowHappened code: 24

Those warnings and audio cuts appear repeatedly and are unrelated to drag and drop. Restarting Mixxx didn't fix it.

I'm currently running some disk I/O tasks in the background, but will keep an eye on that!

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2017-12-14T06:44:03Z


Might the drop outs be caused by theses recent changes?

https://github.com/mixxxdj/mixxx/pull/894

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2017-12-15T13:45:31Z


I didn't notice any more drop outs at 10 ms: https://github.com/mixxxdj/mixxx/pull/1415

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2017-12-16T12:38:36Z


By doing a git bisect I was able to locate the cause of the buffer underflows in the networkclockref branch, i.e. https://github.com/mixxxdj/mixxx/pull/894.

Unfortunately the code does not compile or Mixxx crashes with this range, so I was not able to identify single commit.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2017-12-17T17:08:03Z


Unfortunately I cannot confirm this. :-/ My Setup:

Ubuntu Trusty, ALSA
internal Souncard: Master
USB Soundcard: Headpones
48000 kHz 5.33 ms
Multi Souncard = Default

I have compared current master 24028f2 with the commit just before merging this f76d5c7

I played a track in deck 1 and analysed a track in deck 2. No overflows in both version. I only notice a cpu usage peak in the old version when analysis starts.

I have started Mixxx with: ./mixxx --developer --logLevel debug

And I have no underflow log entries.

2.67 ms does not work at all. There is a kind of deadlock in the alsa code. This is a known issue https://bugs.launchpad.net/mixxx/+bug/1310553

What is your test case?

mixxxbot commented 2 years ago

Commented by: Pegasus-RPG Date: 2017-12-20T00:15:30Z


If this is latency-dependent, why does the CPU meter not indicate a problem? (Mine is very low in the green even while the problem manifests.)

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2017-12-20T00:27:30Z


Which engine clock do you use?

mixxxbot commented 2 years ago

Commented by: Pegasus-RPG Date: 2017-12-20T01:01:53Z


Default (long delay)

mixxxbot commented 2 years ago

Commented by: Pegasus-RPG Date: 2018-01-17T17:48:58Z


Possible duplicate? https://bugs.launchpad.net/mixxx/+bug/1300664

mixxxbot commented 2 years ago

Commented by: Be-ing Date: 2018-03-19T14:52:45Z


What is the status of this? It is marked as In Progress but there is no open pull request. Should we push it back to 2.2?

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2018-03-24T09:06:33Z


I have to free that up for now, because I cannot reproduce this.

mixxxbot commented 2 years ago

Commented by: Pegasus-RPG Date: 2018-04-18T18:38:55Z


Why is this not appropriate for 2.1.1? We haven't released it yet. :)