search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.52k stars 1.28k forks source link

Tango Skin adjustments #9145

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: kazakore Date: 2018-02-21T20:44:04Z Status: Opinion Importance: Undecided Launchpad Issue: lp1750902

As mentioned in the forum here are a few points with regard the Tango skin I think would help it match the others and the way many users (or at least myself) are used to seeing the controls. Much of it is user preference rather than strictly right or wrong so there may be arguments against changing some of it, or possibly more suitable as an additional option rather than a fixed change. Point A is the only one I would say is strictly a Bug.

A. When selecting Symmetric Time/Duration the Artist/Title does not get correctly aligned to the right-hand edge.

B. All other four deck layouts with parallel waveforms go in the order CABD whereas Tango goes ABCD. This should be standardised.

C. In all other skins and I think it would be generally be expected for the Mixer components to be in the middle, currently the Pitch Faders sit inside of the Mixer section and this seems strange to me.

D. When using Symmetric Overview I feel the BPM & Artist/Title should be at the top of the display with the waveform underneath it, currently it is the other way around. This gives you the parallel waveforms sitting ontop of the full track waveform and I think that looks messy.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-02-22T12:42:43Z

Re:A Yes, this can be fixed

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-02-22T12:42:48Z

Re:B This ABCD order derives from the idea to have the scrolling waveforms stacked like the decks in 4-deck mode. Me and other users on the forum had difficulties to relate those waveforms to respective decks with the standart layout.

As a compromise I'd offer to couple the "(a)symmetric overviews" option to the order of scrolling waveforms.

Tango default:

Symmetry option:

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-02-22T12:56:22Z

Re:C Tango has a different mixer concept. IMO this only makes sense if a deck's mixer stays attached to the deck = most important deck controls in one place. Putting the pitch sliders in between decks and mixer would break this. Also, as you may have noticed, the large CoverArt is somehow bound to the mixer palcement. Changing the mixer would require quite a few changes behind the scenes which are not worth the effort IMO, regarding users already got used to the different approach in Tango.

mixxxbot commented 2 years ago

Commented by: kazakore Date: 2018-02-22T13:33:54Z

"Re:B This ABCD order derives from the idea to have the scrolling waveforms stacked like the decks in 4-deck mode. Me and other users on the forum had difficulties to relate those waveforms to respective decks with the standard layout."

Fair enough, as I said it's user preference really, and after posting I did find other skins that use the ABCD order so it's definitely not only this skin. A symmetry option as suggested would be appreciated though.

As to point C: That makes sense and I had a suspicion that may be the case. Pretty sure if I was to try using it with the mouse I would end up pulling on the volume fader when I meant to adjust pitch but as you say, people will get used to it if they wish to use it and operating the GUI with the mouse is pretty rare.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-03-01T14:41:07Z

The alignment of Artist/Title was fixed in https://github.com/mixxxdj/mixxx/pull/1527

There's no real nead to test this regarding Artist/Title, but this PR contains very urgent fixes for HiDPI scaling https://bugs.launchpad.net/mixxx/+bug/1751290. So in case you have a HiDPI screen, it would be nice if you test it.

(optional) Sorting of waveforms will happen in another PR, not sure if I can make it before 2.1 release.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-03-01T14:42:51Z

I'm also thinking about changing the waveform background colors and text colors for artist, duration etc. The blue becomes very annoying, whereas I like the purple of deck 3/4. Any ideas, suggestions?

mixxxbot commented 2 years ago

Commented by: kazakore Date: 2018-03-03T11:55:16Z

I think I personally prefer the blue to the purple/magenta. Obviously you need to bear in mind to keep the colour of the background different enough to those used for the waveform no matter what settings the user has for waveform display. I assume this is why you already have a darker colour background and lighter colour text but closely related to each other....

Sorry to not be of more help.

So the fix of the text alignment has been merged? I don't see it yet on my system. Do I need to delete the Skin folder before updating? I vaguely remember reading of a bug on the forum that this doesn't work properly but thought/hoped only when upgrading from 2.0. But then again, as the Users Skin folder doesn't work it's definitely safer not to have the System Skins folder rewritten!...

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-03-03T18:35:13Z

Never mind, the colors are not a pressing issue. It's just that I'm annoyed by them. I have a private branch anyway, so I'll tackle this some time after 2.1 release...

The alignment is fixed, but the builds may be delayed a bit. As long as you didn't completely restructure the skin but only changed a few lines, any update should overwrite your changes in already existing files. For a personal skin, just copy and rename an existing one so that it won't ever be overwritten by official updates. Hope that's what you meant..