mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.4k stars 1.26k forks source link

skin > tango > add option to hide vinyl control #9199

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: foss-4 Date: 2018-03-25T14:15:51Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1758671 Tags: polish, skin Attachments: tango-vinyltoggle.png


I'd assume less than 50% of mixxx users even use vinyl control. this is a request to

  1. add skin option to hide vinyl control options from UI
  2. default to hiding those options

Obviously low priority. But since almost all Deck controls can be enabled / disabled I found it odd, that there was no option for vinyl control.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-03-25T18:34:52Z Attachments: tango-vinyltoggle.png


Did you try the button next to overview? It expnads vinyl controls per deck.

mixxxbot commented 2 years ago

Commented by: foss-4 Date: 2018-03-26T08:31:51Z


Yes, I understand vinyl control can be collapsed / uncollapsed. But since almost all other UI elements in the deck can be hidden, why not allow hiding vinyl control? If users are not using vinyl control, even collapsed state adds no value to the UI in their use-case.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-03-29T22:47:32Z


I see your point, that option would follow the Tango design idea to hide unused and distracting controls. Does the vc toggle really distract you? It is so tiny and unobtrusive compared to other controls like the mixer or the waveforms where hiding makes much more sense. I never used vinyl control, I just need Passthrough every now and then (which is also the reason vc is expandable per-deck) and I don't notice that button.

Another reason I'm reluctant to add this control is that it would require two steps to have vinyl controls fully expanded.

mixxxbot commented 2 years ago

Commented by: foss-4 Date: 2018-04-07T10:58:56Z


Elaborating on filing request (partly repeating what was already said):

Default can be to show this. Anybody using passthrough would obviously not want to hide the vinyl control, so I don't quite understand the argument that additional clicks would be added for those users by the requested enhancement.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-04-07T12:27:29Z


Yes, with default On this works like before. Don't get me wrong, I'd implement it, just not now. I'm pretty sure other issues will pop up after the release. I'd appreciate to collect those and fix them at once.

mixxxbot commented 2 years ago

Commented by: foss-4 Date: 2018-04-08T08:13:10Z


Sure, no rush. Just put it on the list of minor things to add when 2.1 stabilizes.