search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.55k stars 1.29k forks source link

rate_ultra: shift whole pitch range up/down #9226

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: ronso0 Date: 2018-04-08T13:14:25Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1762172

This is a request from a fellow vinyl DJ who is used to ultra-pitch feature of some older Vestax turntables, but kind of fell in love with Mixxx and my Reloop TerminalMix recently. If I understood it correctly, on those devices you could shift the pitch range center with a small slider, while you could still fine-tune the speed with the actual pitch slider.

Example: speed up the track to +30% with ultra pitch, then you can use the regular pitch fader (+-10%) to fine-adjust the speed between +20% and +40%.

This allows to beatmatch tracks which are too different to be mixed with the regular +/-8% pitch range. Increasing the pitch range to something like 50% provides the sufficient range but apparently lacks the fine-grained control.
For various reasons, pushing the Sync button is also not an option... ;)
mixxxbot commented 2 years ago

Commented by: daschuer Date: 2018-07-20T05:33:21Z

We already have the rateRange control. However this is not scaled well to fit on a knob control. It sounds as if this does not suite, right? It sounds as if the knob is a coarse rate slider that keeps the normal rate slider on 8 %.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2018-07-20T05:40:59Z

These buttons are already possible. https://www.amazona.de/test-reloop-rp-7000mk2-dj-plattenspieler/3/ But are we able to fully emulate this turntable? What does the center led?

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-07-20T12:03:57Z

I think that's the turntable my friend referred to and the feature is called Ultra Pitchfader: Vestax PDX2000 https://www.emusician.com/gear/vestax-pdx-2000

"However, the turntable's ULTRA PITCHFADER makes up for this limitation by allowing users adjust therotation speed ±50 percent. The fader works in conjunctionwith the traditional Fine Pitch fader, which provides control overa ±10 percent range, giving a total of ±60 percent pitchadjustment. This means you can slow records down well below 16 rpmor speed them up much faster than 78 rpm to match any desiredtempo."

Example: speed up the track to +30% with ultra pitch, then you can use the regular pitch fader (+-10%) to fine-adjust the speed between +20% and +40%.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2018-07-20T13:44:39Z

ok, it sounds the same like Reloop did. The center Led means, no ultra pitch offset. I think we can provide controls for both interfaces. How would this be presented in skins?

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2018-07-20T14:35:21Z

I think we need two things: 1) an optional 2nd ultra pitch fader that shifts the pitch range 2) labels for the regular pitch fader that display the lower & upper limit. any pitch range offset is visible then even if the ultra pitch fader is hidden.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2018-07-25T21:23:50Z

first step is done: https://github.com/mixxxdj/mixxx/pull/1765

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2018-08-01T07:06:08Z

the second step is here: https://github.com/mixxxdj/mixxx/pull/1767