Deere skin has no Sample gain knob

[mixxxbot]

Reported by: daschuer Date: 2018-04-14T14:08:48Z Status: Fix Released Importance: Medium Launchpad Issue: lp1763953 Tags: easy Attachments: [Screenshot from 2018-04-30 20-14-16.png](https://bugs.launchpad.net/bugs/1763953/+attachment/5130931/+files/Screenshot from 2018-04-30 20-14-16.png), sampler_text_row.xml

---

I think our default skin should have such a knob.

Discovered here: https://www.mixxx.org/forums/viewtopic.php?f=6&t=11707

[mixxxbot]

Commented by: wunjo Date: 2018-04-28T20:07:45Z

---

It is my preferred skin and I can't use it now

[mixxxbot]

Commented by: daschuer Date: 2018-04-30T14:34:32Z

---

Do you have interest to look into this yourself?

I think you need to edit this file: https://github.com/mixxxdj/mixxx/blob/12da5a54eedba3376ea2186dcb4cf01d4e1a6b8a/res/skins/Deere/sampler_controls_row.xml

and add something like

<Template src="skin:mixer_column_gain_levels.xml"/>

or the content of mixer_column_gain_levels.xml

[mixxxbot]

Commented by: uklotzde Date: 2018-04-30T18:17:51Z Attachments: [Screenshot from 2018-04-30 20-14-16.png](https://bugs.launchpad.net/mixxx/+bug/1763953/+attachment/5130931/+files/Screenshot from 2018-04-30 20-14-16.png)

[mixxxbot]

Commented by: uklotzde Date: 2018-04-30T18:19:33Z Attachments: sampler_text_row.xml

[mixxxbot]

Commented by: uklotzde Date: 2018-04-30T18:22:58Z

---

I've added a gain knob to the top row, just a hack. This would be my preferred solution.

[mixxxbot]

Commented by: Be-ing Date: 2018-05-01T03:54:58Z

---

I would not like the gain knob cluttering the simple sampler view, but it could be added to the expanded view. As a workaround, you could also apply gain to your samples in Audacity or a DAW so you don't need to keep adjusting the gain knob in Mixxx.

[mixxxbot]

Commented by: wunjo Date: 2018-05-04T23:29:16Z

---

@ Uwe Thanks for the xml! Don't know much about coding, so where does I have to place this piece to make it work? Just for personal use I don't matter much for cluttering to make it work. @ Be I understand your style concerns. Using a DAW isn't exactly flexible.

[mixxxbot]

Commented by: wunjo Date: 2018-05-04T23:36:57Z

---

In the expanded view is my preferred option.

[mixxxbot]

Commented by: uklotzde Date: 2018-05-05T12:16:31Z

---

https://github.com/mixxxdj/mixxx/pull/1657

[mixxxbot]

Commented by: wunjo Date: 2018-05-07T23:07:49Z

---

Thanks for the link, will check it on my PC

[mixxxbot]

Issue closed with status Fix Released.