search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.43k stars 1.27k forks source link

Add support for new iTunes Grouping Tag (ID3v2) #9315

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: uklotzde Date: 2018-05-27T17:45:49Z Status: Fix Released Importance: Wishlist Launchpad Issue: lp1773683 Tags: metadata

Apple has (silently?) changed the mapping for the Grouping field to ID3v2 tags in iTunes 12.5.4.42:

https://community.mp3tag.de/t/work-name-name-and-movement/18175 https://community.mp3tag.de/t/work-grouping-fields-itunes-12-5/18659 https://community.mp3tag.de/t/support-for-new-itunes-grouping-id3-frame-grp1/18523

http://mutagen.readthedocs.io/en/latest/api/id3_frames.html#mutagen.id3.GRP1 https://github.com/quodlibet/mutagen/issues/304 https://github.com/quodlibet/mutagen/commit/d7f7ef008eed860c0e4909e32cc6a353cb9a0669

This conflicts with the mapping to "Content group description" as proposed by MusicBrainz Picard: https://picard.musicbrainz.org/docs/mappings/

We need a concept how to deal with those differences.

Import ID3v2 tags: Prioritize MusicBrainz over Apple

Export ID3v2 tags: Try to avoid redundant information in multiple frames

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2018-05-28T22:40:26Z

http://www.jthink.net/jaikozforum/posts/list/19698.page

"So actually for ID3 formats the old grouping field is actually TIT1, and this was used by users to store things like genres. However when iTunes added support for classical music work and movements they decided to use TIT1 to store the work, and created a new field called GRP1 that mapped to their Grouping field.

So we now have the situation that most tools use TIT1 (also known as Content Group Description) for grouping, but iTunes uses it for Classical works and uses GRP1 for grouping, this affects Mp3 and Aif, there is not a problem with other formats."

Also here: http://blog.jthink.net/2016/12/itunes-add-new-grouping-field-but.html

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2018-05-29T06:09:40Z

Since we cannot know if it is a track from ITunes or an other player, we can either ignore the issue, shiw both fields or add an iTunes compatibility mode, right?

Can we distinguish ITunes tracks from others somehow?

Is this bug a real user request, or just a finding? I tend to ignore this until we have a user suffering this. Maybe there is a chance to solve his specific problem then.

What do you think?

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2020-01-01T11:13:21Z

Already fixed on master.

mixxxbot commented 2 years ago

Issue closed with status Fix Released.