search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.5k stars 1.28k forks source link

Crash/Freeze while analyzing tracks #9443

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: randombyte-developer Date: 2018-09-19T20:56:32Z Status: Fix Released Importance: Critical Launchpad Issue: lp1793387

When analyzing the file "Komik -Achmet - PC Probleme.mp3" (will be sent via PM), Mixxx freezes when it is loaded into a deck. Mixxx crashes when it tries to analyze it with the "Analyze all" features.

The same is for the file "Anti-Flag - Fuck Police Brutality.mp3".

The last bits of the mixxx.log for the first track is: https://gist.github.com/randombyte-developer/dd40e3b049c80fa3ac8ca2ab01c8e45d

The backtrace with gdb for the first file is this: https://gist.github.com/randombyte-developer/a3c961e380186848ac0f0701ebcb2271

Backtrace for the second track: https://gist.github.com/randombyte-developer/e35d77a17e7c158b5d8f74c072f6ae5d I had to suspend the Mixxx process for the second file, to enter any commands into gdb.

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2018-09-19T21:16:32Z

This file is really corrupt, please exclude it from your library:

Critical [AnalyzerThread 0 mixxxdj/mixxx#4910]: DEBUG ASSERT: "madSynthChannelCount <= channelCount()" in function virtual mixxx::ReadableSampleFrames mixxx::SoundSourceMp3::readSampleFramesClamped(mixxx::WritableSampleFrames) at src/sources/soundsourcemp3.cpp:664

The number of channels for the decoded MP3 frames seems to switch between 1 and 2.

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2018-09-19T21:21:08Z

Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad big_values count
Debug [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: lost synchronization
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: forbidden bitrate value
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: forbidden bitrate value
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: forbidden bitrate value
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: forbidden bitrate value
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: forbidden bitrate value
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: Huffman data overrun
Debug [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: lost synchronization
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Debug [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: lost synchronization
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: bad main_data_begin pointer
Debug [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: lost synchronization
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: forbidden bitrate value
Info [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Recoverable MP3 frame decoding error: reserved sample frequency value
Warning [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - MP3 frame header with mismatching number of channels 2 <> 1
Warning [AnalyzerThread 0 mixxxdj/mixxx#4910]: SoundSourceMP3 - Reading MP3 data with different sample rate 22050 <> 44100
mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2018-09-19T21:29:12Z

We should stop decoding when encountering the very first inconsistency, no matter how serious it is.

mixxxbot commented 2 years ago

Commented by: uklotzde Date: 2018-09-19T21:39:20Z

https://github.com/mixxxdj/mixxx/pull/1813

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2018-09-19T21:44:38Z

I can confirm the crash with "Komik -Achmet - PC Probleme.mp3" Anti-Flag - Fuck Police Brutality.mp3 works, but has loud audio artefacts.

Both files are playing with Totem but also have artefacts.

"die VGDEA.exe kopiert sich selbst in die config.sys" zum schieflachen. :-)

mixxxbot commented 2 years ago

Issue closed with status Fix Released.