search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.52k stars 1.28k forks source link

mixxx-2.2.3 linked against QT 5.14 - faders disappear in Deere skins #9854

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: anton-gubarkov Date: 2019-12-29T13:48:39Z Status: Fix Released Importance: Low Launchpad Issue: lp1857813 Tags: skin, usability Attachments: [video of the UI problem with QT 5.14](https://bugs.launchpad.net/bugs/1857813/+attachment/5316231/+files/video of the UI problem with QT 5.14), patch-lp1857813-git-master-r7055.diff

I recently updated the QT library in my laptop and now the faders for 2 decks are visible only when they are in the topmost position. As soon as I move them down, the fader becomes invisible.

I've recorded a short video illustrating the problem.

mixxxbot commented 2 years ago

Commented by: anton-gubarkov Date: 2019-12-29T13:48:39Z Attachments: [video of the UI problem with QT 5.14](https://bugs.launchpad.net/mixxx/+bug/1857813/+attachment/5316231/+files/video of the UI problem with QT 5.14)

mixxxbot commented 2 years ago

Commented by: anton-gubarkov Date: 2019-12-29T13:50:24Z

my system information: PF16W6Y2 ~ # uname -a Linux PF16W6Y2 5.3.18-gentoo #⁠1 SMP PREEMPT Thu Dec 19 22:34:27 MSK 2019 x86_64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz GenuineIntel GNU/Linux

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2019-12-29T14:31:48Z

This looks really weird... Can you reproduce this with other skins as well?

Also, how does it look weh nyou build master with Qt 5.14?

mixxxbot commented 2 years ago

Commented by: anton-gubarkov Date: 2019-12-30T06:16:19Z

I tested all skins. Only Deere and Deere 64 samplers are affected. All other skins work ok.

mixxxbot commented 2 years ago

Commented by: dgbirm Date: 2019-12-30T06:19:01Z

Having the same issue. Just built mixxx on Manjaro Linux 18.1.5. Problem is isolated to Deere:

Debug [Main]: "Mixxx" "2.3.0-alpha-pre" "(git master r7051; built on: Dec 30 2019 @ 00:23:10; flags: asan=0 battery=1 buildtime=1 bulk=1 color=0 coreaudio=0 faad=0 ffmpeg=1 hid=1 hss1394=0 lilv=1 localecompare=1 macappstore=0 mad=1 mediafoundation=0 modplug=1 optimize=native opus=1 perftools=1 perftools_profiler=1 profiling=0 qt_sqlite_plugin=0 qtkeychain=1 shoutcast=1 shoutcast_internal=0 test=1 tsan=0 ubsan=0 verbose=1 vinylcontrol=1 wv=0)" is starting...
Debug [Main]: Compile time library versions:
Debug [Main]: Qt: 5.14.0
mixxxbot commented 2 years ago

Commented by: esbrandt Date: 2020-01-07T15:20:00Z Attachments: patch-lp1857813-git-master-r7055.diff

Can conform the issue since upgrading from QT 5.13 to 5.14. MacOS 10.14.6 2.3.0-alpha-pre (build master r7055).

There was a svg viewport fix in 5.14 worth investigating https://bugreports.qt.io/browse/QTBUG-70256

Another aspect of the bug is that stretching images inside mixxx do not work as they used to be. As seen in OP´s video #⁠1. The crossfader slider stretch is off, compared with QT 5.13.

Also, at least on macOS, there are major performance issues with this specific QT version. On my machine, mixxx is at 100% CPU even while idle, just trying to render images.

It appears there have been some changes to the graphics stack . https://wiki.qt.io/Qt_5.14_Release

As a stop-gap solution, i simplified the affected svg graphics for the Deere skin. There was some transformation going on (that rotates a shape around the point 0,0), also the unscaled handle graphics were bigger than the slider graphics. That was apparently not an issue until now.

At last, i added a maximum size for the crossfader slider image to stop the crossfader handle from overflowing the background graphic.

As said, apparently there is an issue with mixxx internal STRETCH image function. The crossfader slider graphic slider-crossfader.svg does not stretch (expand) correct to the sliders widget size, but the slider-crossfader-AutoDJ.svg , active when using AUTODJ and defined in style.qss does.

Please test.

mixxxbot commented 2 years ago

Commented by: esbrandt Date: 2020-01-17T12:27:57Z

https://github.com/mixxxdj/mixxx/pull/2452

mixxxbot commented 2 years ago

Commented by: pisingallo Date: 2020-01-28T12:54:26Z

any chance this could be backported to the v2.2.3 branch? This is very important

mixxxbot commented 2 years ago

Issue closed with status Fix Released.