search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.52k stars 1.28k forks source link

Tango Skin: Labels are disapearing from button parameters #9863

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: daschuer Date: 2020-01-14T17:57:57Z Status: New Importance: Undecided Launchpad Issue: lp1859654

After Restart Mixxx, the button parameters have labels like "Quantize".

If I toggle the effect the labels of the disables buttons disappears. The enabled buttons have always their labels.

Tested with current Master r7066 on Ubuntu Trusty.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2020-01-15T07:41:28Z

I could not reproduce with Bionic. Only once after restart a parameter label was invisible until I toggled it on & off. After that I could not reproduce it at all.

There are two fx parameter labels stacked with different font colors to match the in/active background. They are connected to FxRack_Unit_FxNum,parameterX [0,1] and I have actually no idea how the enabled state of the entire effect should affect those conections :\
Maybe we really have an issue with how the controls are updated, like the 'passthrough' control that sometimes isn't correctly switched back to 0 after a failed attempt to toggle passthrough without vinyl set up.

I'll prepare a little PR that changes the conections from [0,1] to [0,not 0], maybe that helps.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2020-01-15T16:43:56Z

Than you for taking care. The issue appears when changing to another effect, not during a enable/disable cycle.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2020-05-29T21:32:11Z

Does it still happen with 2.2.4 or 2.3?