mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.54k stars 1.28k forks source link

some way to pick the right track harmonically #9896

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: mevsme Date: 2020-03-09T21:05:49Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1866706 Tags: key, library Attachments: [Screenshot of Harmonic Mix app for Android.](https://bugs.launchpad.net/bugs/1866706/+attachment/5585328/+files/Screenshot of Harmonic Mix app for Android.)


Mixxx shows keys but actually there is no use for them. Picking a song based on the key is very long process. How I see it: 1) open on a cell phone the picture of circle of fifth 2) find the key of your song, 3) pick another suitable key for the next song 4) search in the playlist for the song with that key (and do C# or Dā™­ math in your brain) 4) don't find it 5) go to 3 6) don't find it 7) go to 3 8) select 9) mix it

I think it's too hard Maybe playlist could have some kind of sorting based on the key that is playing now or some shades of colors to mark the keys that fits well to the given key

or circle of fifth pop up

for now harmonic mixing is tough

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2020-03-09T23:18:56Z


You can search for "key:~A" and the library will search for tracks compatible with the key of A (not just in A).

mixxxbot commented 2 years ago

Commented by: ywwg Date: 2020-03-09T23:20:31Z


oops, I mean: "~key:c#m" as shown in the manual: https://www.mixxx.org/manual/2.2/en/chapters/library.html

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2020-03-10T11:39:03Z


related PR: "Add harmonic keywheel ui" https://github.com/mixxxdj/mixxx/pull/1695

mixxxbot commented 2 years ago

Commented by: mxmilkiib Date: 2022-04-30T08:16:47Z Attachments: [Screenshot of Harmonic Mix app for Android.](https://bugs.launchpad.net/mixxx/+bug/1866706/+attachment/5585328/+files/Screenshot of Harmonic Mix app for Android.)


An additional method would be to make the harmonic wheel react, like https://play.google.com/store/apps/details?id=mezcla.armonica.para.dj

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2022-04-30T14:24:06Z


Your link is dead, I think it is: https://play.google.com/store/apps/details?id=mezcla.armonica.rueda.camelot&hl=de&gl=US

In addition I have found here a complete description of key transitions: http://blog.dubspot.com/harmonic-mixing-w-dj-endo-part-1/

Maybe we can use this knowledge somehow ...

mixxxbot commented 2 years ago

Commented by: geozubuntu Date: 2022-05-02T20:00:58Z


To make long story short, it is very easy to mix harmonically using the Camelot system (in mixxx it is named Lancelot - may I ask why?)...

Anyway, Lancelot keys consist of a number and a letter. Let's say 5A. Of course it matches every other track with the same key 5A. Then harmonic matches consist of only one digit change. 5A can be 4A or 6A (keep the letter and change the number by one ) or 5B (keep number and change letter by one). Only one change at a time. If we change both the letter and the number it is NOT harmonic match. The same way 6B can only be 6B, 5B, 7B, 6A.

The best explanation is given by the creators of the harmonic spin wheel in below link which promotes their software, of course, but the explanations given are crystal clear.:

https://mixedinkey.com/harmonic-mixing-guide

It would be very helpful if mixxx could assist us in harmonic and/or beat mixing.

Think: Auto DJ except from random track addition could have checkboxes to add automatically harmonic/beat matching tracks.

@šŽš°šžš§ š–š¢š„š„š¢ššš¦š¬ (š²š°š°š ) Sorry friend, but searching has some problems and it is not working as expected. (Related to bug 1967667 (?)). Unfortunately let's say for ~key:5A or ~key:"5A" it should only return 4A,5A,6A and 5B because only these keys are harmonically matched. But search returns also 6B which is NOT harmonically matched to 5A so it can confuse users and/or negatively affect mixing. And "~key:5A" with quotes returns nothing at all.

One more time thanks for your efforts.

mixxxbot commented 2 years ago

Commented by: daschuer Date: 2022-05-03T19:18:18Z


I consider 5A and 6B compatible. We only change one tone and we go from minor to a mayor key, which sounds good. You need consider that a minor track contains also mayor chords and there are many tracks where I cannot rate a track unambiguous as mayor or minor. That's why we return 6B as well. It this an issue for your?

mixxxbot commented 2 years ago

Commented by: geozubuntu Date: 2022-05-05T20:41:17Z


Since it is made on purpose It's OK with me, most of the time. Just a little more concentration not to drop a 6b when I don't want to jump and change from major to minor and vice versa. No big deal.

mxmilkiib commented 1 year ago

There is the harmonic wheel popup window now, but it's inert. image

The DJ Harmonica Mix app with 1A selected; image

If the user could manually select a key in the Mixxx popup for the same info the app gives, that would be a great next step in improving harmonic mixing using Mixxx.

As, AFAIU, there isn't a clear way to automatically know what deck is the current main deck, so as to display its key, so having buttons in the popup for each deck would allow that to be manually chosen.

mxmilkiib commented 1 year ago

I'm possibly willing to pay to have the harmonic wheel popup window updated to have buttons for the decks available, so that clicking on a deck button will take the key from that track and reflect all the relavent harmonic options, like the DJ Harmonica Mix Android app does when one of the keys on it is tapped.

How much for a bounty like this?

ronso0 commented 1 year ago

@mxmilkiib Are you aware of the "Search reated Tracks" menu? (new in Mixxx 2.4. IIRC, not sure if this was already mentioned in this context). There is a Key action: image I guess the menu can be extended to show the compatible keys, just to have some more info.

Overhauling the keywheel widget (interactive, deck selector, search button(s)) is certainly possible, but actually it'd be a rewrite as far as I can tell.

Swiftb0y commented 1 year ago

Do we also need to make it configurable what people consider to be compatible? We consider the adjacent 6 keys to be compatible while a previous commenter only considered the more conservative 4 adjacent keys to be compatible. Now the app mentioned by @mxmilkiib considers even more keys compatible. It seems like for any implementation, people will complain about false-positive/-negative matches due the matching being too loose/strict.

mxmilkiib commented 1 year ago

I'm aware of that menu feature, and the library key search feature. These though require live interaction with the app, and I'm seeking a direct visualisation for matches that doesn't require any live interaction.

That Mixxx has no visual indicator to aid harmonic mixing is my big problem. I am thinking now that #5655 is more important than focusing on an updated harmonic wheel popup.