search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.49k stars 1.28k forks source link

access \ edit track properties from Computer library entry #9897

Open mixxxbot opened 2 years ago

mixxxbot commented 2 years ago

Reported by: mevsme Date: 2020-03-09T21:15:30Z Status: Confirmed Importance: Wishlist Launchpad Issue: lp1866707

I tend to use folders of "Computer" than playlists or library to pick up songs. So to be able to edit artist or comment or title, I need to use playlists or 3rd party software. Can mixxx offer some basic id3 tag editing available from built in file browser?

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2020-03-10T12:09:09Z

Unless you're looking for a mass-editing tool, we already provide that functionality. I just tried the following in master:

There'll be a popup saying:

Mixxx may wait to modify files until they are not loaded to any decks or samplers. If you do not see changed metadata in other programs immediately, eject the track from all decks and samplers or shutdown Mixxx."

If you want to try a master (alpha) build, head over to http://downloads.mixxx.org/builds/master/release/ and pick a built for your OS. ! Remember to back up your config and database before you install an alpha build. Info on that is there https://www.mixxx.org/wiki/doku.php/testing

mixxxbot commented 2 years ago

Commented by: mevsme Date: 2020-03-14T17:03:17Z

Can I have 'properties' right click menu entry in file browser part of library?

The thing is that it is impossible to find a track\audio file without ID3 tags in library, but you can easily find them in file browser, but there is no way you can edit them easily to fill up the missing id3 tags\propeties.

ronso0 commented 2 months ago

Just stumbled over this again, here's some update / clarification (using Mixxx 2.5, not verified with earlier versions).

Track Properties is for editing the metadata of tracks in the library. The underlying issue here is that "Computer" (and Recordings) is kind of a file browser, i.e. it shows track files that may or may not be in the Mixxx library and reads the file tags. (sorry I didn't notice/consider this fact earlier)

When editing a track in Computer that is not yet in the Mixxx library like this (or Recordings, add a track file to the Recordings directory, for simplicity)

the track file is imported into the Mixxx library (here) and the edited metadata is saved (in the library). --> This can be verified by going to Tracks, find that track, check edited metadata.

However, Computer is still just a file parser (id3/other tags), so when going to Recordings again, Mixxx still doesn't care whether that track is in the library or not, so it'll again read the file tags, and the edited values won't be visible, yet, unless the metadata has been exported to file tags explicitly. (export tags to track files as described above).

Would be cool if BrowseThread / BrowseTableModel would recognize library tracks and use that metadata instead of file tags. (the fix is actually just a few lines in BrowseThread, but is not applicable due to thread affinity assertions in TrackCollection / ~Manager)