search

mixxxdj / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4.51k stars 1.28k forks source link

don't change effect when scrolling over WEffectSelector #9995

Closed mixxxbot closed 2 years ago

mixxxbot commented 2 years ago

Reported by: ronso0 Date: 2020-05-31T16:24:43Z Status: Fix Released Importance: Low Launchpad Issue: lp1881493 Tags: effects, usability

I see the scrolling feature of WComboBox is supposed to improve accessibility but here it can be realy annoying: a few times I accidentially scrolled with my touchpad when hovering an effect seletor. When this effect is currently active this can be a show killer, say you switch from a centered filter effect to BitCrusher.. Also any custom Super knob link mapping as well as custom parameters are reset.

The entire effect selector area is clickable thus I think it's sufficient to open the drop-down on click for switching effects and we should disable the scroll feature.

mixxxbot commented 2 years ago

Commented by: ronso0 Date: 2020-07-07T12:44:40Z

https://github.com/mixxxdj/mixxx/pull/2923

mixxxbot commented 2 years ago

Issue closed with status Fix Released.