miyabi / react-native-safe-area

React Native module to retrieve safe area insets for iOS 11 or later.
MIT License
113 stars 23 forks source link

Return some reasonably top safeArea for ios < 11. #1

Closed jainkuniya closed 6 years ago

jainkuniya commented 6 years ago

Eailer it was returning 0 for iOS < 11, thus making content to overlap status bar.

borisyankov commented 6 years ago

This is important, as using the component on iOS 10 results in a broken layout. I think this needs to take into account if the status bar is shown though.

miyabi commented 6 years ago

@vishwesh3 Thank you for your PR!

miyabi commented 6 years ago

@vishwesh3 I added some code to fix any other problems about status bar. Please check it!

jainkuniya commented 6 years ago

cool! tested on iOS < 11. It is working fine 👍 Now we have upgraded to v0.2.1. If we will face any problem then will open issue (even love to work on it :))