miyabi / react-native-safe-area

React Native module to retrieve safe area insets for iOS 11 or later.
MIT License
113 stars 23 forks source link

Fix cycle requirements warning #12

Closed ITJesse closed 5 years ago

miyabi commented 5 years ago

@ITJesse Thank you for your PR! But the commit dcab06e4efca15028524be3282dd51fbd352d353 is not related the main problem and it doesn't work. (wrappedRef will be always null) Could you revert this commit?

miyabi commented 5 years ago

@ITJesse To release new version, I will merge this PR and revert the unrelated commit by myself. Thanks!

ITJesse commented 5 years ago

Thank you.

2019年5月3日(金) 15:55 Masayuki Iwai notifications@github.com:

Merged #12 https://github.com/miyabi/react-native-safe-area/pull/12 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/miyabi/react-native-safe-area/pull/12#event-2316517878, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3PHYFV73BNVAMRXIKT273PTPOVLANCNFSM4GRIS77Q .