miyagawa / Carmel

CPAN Artifact Repository Manager
Other
138 stars 17 forks source link

in update, no need to remove it from the snapshot #66

Closed miyagawa closed 2 years ago

miyagawa commented 2 years ago

When carmel update runs, the code searches on CPAN for a new version, and when it is found, the module is removed from the snapshot. So that later search won't find the version that's pinned.

This seems unnecessary, since we update $requirements to point to the new version, whether it's pinned or not, and that will be passed to Menlo and it will do the right thing.

The only situation it could behave differently is that if the snapshot has a higher version than what is currently up on CPAN. The current code (removing it from snapshot) will downgrade to the CPAN version. By keeping the snapshot, the new behavior is to prefer the snapshot.

I think the new behavior is fine, and you can always downgrade with carmel update Module@version.