--preload-app missing from proctitle

miyagawa / Starman

Starman is a high-performance preforking Perl PSGI web server

http://search.cpan.org/dist/Starman

Other

287 stars 84 forks source link

--preload-app missing from proctitle #118

Open ctriv opened 9 years ago

ctriv commented 9 years ago

If you startup starman with the --preload-app option, it won't appear in the proc title for starman:

$ starman --preload-app schema.psgi 
$ creinhardt@creinhardt:~$ ps -ef | grep 'starman master'
  501 59500 59203   0  1:56PM ttys009    0:00.58 starman master schema.psgi

ctriv commented 9 years ago

I forgot to mention, this is Starman 0.4014 running on perl 5.20.3.

miyagawa commented 9 years ago

It is expected: the proctitle doesn't really mean to represent the actual command. "starman worker ..." isn't even a command :)

ctriv commented 9 years ago

But other command line options are in the proctitle (--listen or the --net_server passthrus). It seems arbitrary that some are and some aren't. This caused a fair amount of confusion where we were looking for a bug in our deployment system because we were expecting --preload-app to be present in the proctitle.

miyagawa commented 9 years ago

OK, i'm open to a PR that adds that.