miyagawa / Starman

Starman is a high-performance preforking Perl PSGI web server
http://search.cpan.org/dist/Starman
Other
287 stars 84 forks source link

Support psgix.cleanup (and psgix.cleanup.handlers) #132

Open jrubinator opened 5 years ago

jrubinator commented 5 years ago

This PR adds psgix.cleanup* handling to Starman.

miyagawa commented 5 years ago

probably a dupe of #53

jrubinator commented 5 years ago

Hmm, I think you're right. Wish I'd done a better job searching for that first 😝

I'll see if I can wake up that seven-year-old PR. Assuming I can, I'm happy to close this one.

jrubinator commented 5 years ago

@miyagawa I think that branch is too old to re-garner momentum. I'm happy to implement turning off keep-alive connections when there are cleanup handlers here, would you be okay with that?

jrubinator commented 5 years ago

I refactored to use #53 (since that correctly handled cleanup-harakiri interaction), and added the requested keepalive handling.

jrubinator commented 5 years ago

:(

ArcticSnowman commented 4 years ago

@miyagawa - any chance this can be merged into a release?