Closed dbeaubien closed 4 years ago
are you trying to suggest that upgrading Atom from 1.46.0 to 1.47.0 generates an error?
I am using 1.46.0 and I don't see any error.
can you please try 1.46.0 and report if there are any differences?
when reporting an issue, it is important to consider the possibility that not everyone is having the same issue, it may be just you.
I am just passing along the issue. It is probably tied to 1.47.0. It actually happens on all these Atom packages: language-4dcatalog, language-4dpreferences, language-4dlink, language-4dproject, and language-4dm
I suspect it is an issue with tree-sitter-json
.
I think it is unsafe to use Atom 1.47.0.
Use 1.46.0.
> tree-sitter-json@0.14.0 install /private/var/folders/19/45d7qmr50rsd5x0w5rrfzr540000gn/T/apm-install-dir-2020421-96884-1wtw1at.uf8f/node_modules/language-4dform/node_modules/tree-sitter-json
> node-gyp rebuild
CC(target) Release/obj.target/tree_sitter_json_binding/src/parser.o
CXX(target) Release/obj.target/tree_sitter_json_binding/src/binding.o
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
../src/binding.cc:13:6: error: variable has incomplete type 'void'
void Init(Handle<Object> exports, Handle<Object> module) {
^
../src/binding.cc:13:11: error: use of undeclared identifier 'Handle'
void Init(Handle<Object> exports, Handle<Object> module) {
^
../src/binding.cc:13:18: error: 'Object' does not refer to a value
void Init(Handle<Object> exports, Handle<Object> module) {
^
/Users/miyako/.atom/.node-gyp/.node-gyp/5.0.13/include/node/v8.h:3257:17: note: declared here
class V8_EXPORT Object : public Value {
^
../src/binding.cc:13:26: error: use of undeclared identifier 'exports'
void Init(Handle<Object> exports, Handle<Object> module) {
^
../src/binding.cc:13:35: error: use of undeclared identifier 'Handle'
void Init(Handle<Object> exports, Handle<Object> module) {
^
../src/binding.cc:13:42: error: 'Object' does not refer to a value
void Init(Handle<Object> exports, Handle<Object> module) {
^
/Users/miyako/.atom/.node-gyp/.node-gyp/5.0.13/include/node/v8.h:3257:17: note: declared here
class V8_EXPORT Object : public Value {
^
../src/binding.cc:13:50: error: use of undeclared identifier 'module'
void Init(Handle<Object> exports, Handle<Object> module) {
^
../src/binding.cc:13:57: error: expected ';' after top level declarator
void Init(Handle<Object> exports, Handle<Object> module) {
^
;
8 errors generated.
make: *** [Release/obj.target/tree_sitter_json_binding/src/binding.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:182:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:237:12)
gyp ERR! System Darwin 19.3.0
gyp ERR! command "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /private/var/folders/19/45d7qmr50rsd5x0w5rrfzr540000gn/T/apm-install-dir-2020421-96884-1wtw1at.uf8f/node_modules/language-4dform/node_modules/tree-sitter-json
gyp ERR! node -v v10.2.1
gyp ERR! node-gyp -v v3.7.0
gyp ERR! not ok
npm WARN enoent ENOENT: no such file or directory, open '/private/var/folders/19/45d7qmr50rsd5x0w5rrfzr540000gn/T/apm-install-dir-2020421-96884-1wtw1at.uf8f/package.json'
npm WARN apm-install-dir-2020421-96884-1wtw1at.uf8f No description
npm WARN apm-install-dir-2020421-96884-1wtw1at.uf8f No repository field.
npm WARN apm-install-dir-2020421-96884-1wtw1at.uf8f No README data
npm WARN apm-install-dir-2020421-96884-1wtw1at.uf8f No license field.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! tree-sitter-json@0.14.0 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the tree-sitter-json@0.14.0 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/miyako/.atom/.apm/_logs/2020-05-20T22_43_00_292Z-debug.log
Since the official tree-sitter-json is not updated (recompiled) yet, I have forked and renamed it as 4djson/fourdjson, recompiled and published on apm.
language-4dform and language-4dproject are updated to link against this fork.
Also, I've recompiled 4dxml and 4dm tree-sitter parsers.
Please let me know if updating the packages removes these errors.
I have updated the packages and all errors are now gone. Thanks for that. :)
[Enter steps to reproduce:]
Atom: 1.47.0 x64 Electron: 5.0.13 OS: Mac OS X 10.14.6 Thrown From: language-4dform package 0.2.0
Stack Trace
Failed to load a language-4dform package grammar
Commands
Non-Core Packages