[MAINT] run test and flake8 github actions

miykael / atlasreader

Python interface for generating coordinate tables and region labels from statistical MRI images

BSD 3-Clause "New" or "Revised" License

88 stars 32 forks source link

[MAINT] run test and flake8 github actions #131

Closed Remi-Gau closed 11 months ago

Remi-Gau commented 1 year ago

[x] upload coverage report
[x] make sure tests pass
[x] rm travis.yml
[x] add GHA workflow
[x] add test data instead of downloading from neurovault to minimize failures
[x] add pre-commit to run flake8 locally upon commit

closes #125, #126
closes #129

Remi-Gau commented 1 year ago

not sure why we are getting this: https://github.com/miykael/atlasreader/actions/runs/6030134696

The runner has received a shutdown signal

Remi-Gau commented 1 year ago

Will let this rest for today. Finishing fixing this may require diving into libraries I am not familiar with.

miykael commented 11 months ago

I was able to make the tests pass, and updated the faulty badges. But now it crashes do to some coveralls issue. Unfortunately I'm not familiar with coveralls or its github-actions. I registered on coveralls.io and added the a token via the command line, but it's still failing. Any idea how to debug this?

Remi-Gau commented 11 months ago

Any idea how to debug this?

the action was fine I just had forgotten to generate the coverage report. 🙈

BTW: added python 3.12 in CI

miykael commented 11 months ago

Oh super! Thank you for all of this! Looks good to me, will go ahead and merge it!