miykael / atlasreader

Python interface for generating coordinate tables and region labels from statistical MRI images
BSD 3-Clause "New" or "Revised" License
89 stars 31 forks source link

ENH: orders clusters by cluster size #55

Closed miykael closed 6 years ago

miykael commented 6 years ago

Closes https://github.com/miykael/atlasreader/issues/46.

This PR changes the process_img output so that the returned cluster image is always ordered by cluster size.

codecov-io commented 6 years ago

Codecov Report

Merging #55 into master will increase coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   90.46%   90.57%   +0.11%     
==========================================
  Files           6        6              
  Lines         325      329       +4     
==========================================
+ Hits          294      298       +4     
  Misses         31       31
Impacted Files Coverage Δ
atlasreader/atlasreader.py 97.3% <100%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 289891e...46ec4ee. Read the comment docs.

miykael commented 6 years ago

@rmarkello - I integrated your approach with https://github.com/miykael/atlasreader/pull/55/commits/46ec4eeb5e75384ad4206e50c6358dc061652505

rmarkello commented 6 years ago

Looks good to me! You ready to merge this?

miykael commented 6 years ago

Yep! Ready to go. You can merge it!