search

miykael / atlasreader

Python interface for generating coordinate tables and region labels from statistical MRI images
BSD 3-Clause "New" or "Revised" License
88 stars 32 forks source link

ENH: Add default atlases #73

Closed miykael closed 5 years ago

miykael commented 5 years ago

Closes https://github.com/miykael/atlasreader/issues/72.

As discussed in https://github.com/miykael/atlasreader/issues/72, this PR adds default atlases. I'm not sure if the name default is the best solution or if we should handle it differently.

codecov-io commented 5 years ago

Codecov Report

Merging #73 into master will increase coverage by 0.15%. The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   91.89%   92.05%   +0.15%     
==========================================
  Files           6        6              
  Lines         358      365       +7     
==========================================
+ Hits          329      336       +7     
  Misses         29       29
Impacted Files Coverage Δ
atlasreader/cli.py 0% <0%> (ø) :arrow_up:
atlasreader/atlasreader.py 97.93% <100%> (+0.04%) :arrow_up:
atlasreader/tests/test_atlasreader.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 673069e...b87ffa1. Read the comment docs.

miykael commented 5 years ago

I think this is ready to be merged. Only open question is if you're happy with the default flag or if we should use something else.

miykael commented 5 years ago

As there are no objections, I will merge this.