search

miykael / atlasreader

Python interface for generating coordinate tables and region labels from statistical MRI images
BSD 3-Clause "New" or "Revised" License
89 stars 31 forks source link

ENH: make cluster extent inclusive #81

Closed miykael closed 5 years ago

miykael commented 6 years ago

It seems that the min_cluster_size parameter was exclusive, i.e. if a cluster size of 100mm^3 was specified, then clusters of 100mm^3 were not shown. I assume that this is due to some rounding issue and comparisons of floats issue.

Reducing the min_region_size value of nilearn.regions's connected_regions function by 1e-8 was in my case enough to take care of this.

codecov-io commented 6 years ago

Codecov Report

Merging #81 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files           6        6           
  Lines         358      358           
=======================================
  Hits          329      329           
  Misses         29       29
Impacted Files Coverage Δ
atlasreader/atlasreader.py 97.89% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ab5324...d554c95. Read the comment docs.