search

miykael / atlasreader

Python interface for generating coordinate tables and region labels from statistical MRI images
BSD 3-Clause "New" or "Revised" License
88 stars 32 forks source link

Add license text from PR #71 to __init__ #88

Closed miykael closed 5 years ago

miykael commented 5 years ago

This PR continues the work under https://github.com/miykael/atlasreader/pull/71, by adding the license text to the __init__.py file. But in contrast to https://github.com/miykael/atlasreader/pull/71, this PR will not create an .imported file, but print the license text the first time the module is loaded within an environment.

codecov-io commented 5 years ago

Codecov Report

Merging #88 into master will increase coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   87.87%   87.93%   +0.06%     
==========================================
  Files           6        6              
  Lines         396      398       +2     
==========================================
+ Hits          348      350       +2     
  Misses         48       48
Impacted Files Coverage Δ
atlasreader/__init__.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f95b64...f2796ec. Read the comment docs.

miykael commented 5 years ago

nilearn==0.5.0 currently leads to the following ImportWarnings when imported:

/home/line/miniconda3/lib/python3.6/importlib/_bootstrap.py:219: ImportWarning: can't resolve package from __spec__ or __package__, falling back on __name__ and __path__
  return f(*args, **kwds)
/home/line/miniconda3/lib/python3.6/site-packages/skimage/__init__.py:80: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/line/miniconda3/lib/python3.6/site-packages/pytest.py' mode='r' encoding='utf-8'>
  imp.find_module('pytest')
/home/line/miniconda3/lib/python3.6/importlib/_bootstrap.py:219: ImportWarning: can't resolve package from __spec__ or __package__, falling back on __name__ and __path__
  return f(*args, **kwds)
/home/line/miniconda3/lib/python3.6/importlib/_bootstrap.py:219: ImportWarning: can't resolve package from __spec__ or __package__, falling back on __name__ and __path__
  return f(*args, **kwds)

This doesn't happen with version 0.5.0a. That's why https://github.com/miykael/atlasreader/pull/88/commits/f2796ec4855a6cd42a8b48181182face79cef36b fixes required version to this value. This restriction can hopefully be removed in the near future.

miykael commented 5 years ago

Will merge this, as al tests pass.