miykael / gif_your_nifti

How to create fancy GIFs from an MRI brain image
BSD 3-Clause "New" or "Revised" License
118 stars 31 forks source link

Bug: incompatible with `imageio` verison 2.28 #12

Closed jamesbraza closed 1 year ago

jamesbraza commented 1 year ago

imageio version 2.28 comes with https://github.com/imageio/imageio/pull/871 which finally came into effect in https://github.com/imageio/imageio/pull/824 no longer works with git_your_nifti:

> gif_your_nifti data/brats2020-training-validation-data/BraTS2020_TrainingData/MICCAI_BraTS2020_TrainingData/BraTS20_Training_354/BraTS20_Training_354_seg.nii
====================
gif_your_nifti 0.2.0
====================
Selections:
  mode = normal
  size = 1
  fps  = 20
Traceback (most recent call last):
  File "/path/to/venv/bin/gif_your_nifti", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/path/to/venv/lib/python3.11/site-packages/gif_your_nifti/__main__.py", line 60, in main
    core.write_gif_normal(f, cfg.size, cfg.fps)
  File "/path/to/venv/lib/python3.11/site-packages/gif_your_nifti/core.py", line 192, in write_gif_normal
    mimwrite(filename.replace(ext, '.gif'), new_img,
  File "/path/to/venv/lib/python3.11/site-packages/imageio/v2.py", line 484, in mimwrite
    return file.write(ims, is_batch=True, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/path/to/venv/lib/python3.11/site-packages/imageio/plugins/pillow.py", line 354, in write
    raise TypeError(
TypeError: The keyword `fps` is no longer supported. Use `duration`(in ms) instead, e.g. `fps=50` == `duration=20` (1000 * 1/50).

Here is the dataset being used.

The version should be pinned in setup.py for those installing like so:

pip install git+https://github.com/miykael/gif_your_nifti.git