search

miykael / gif_your_nifti

How to create fancy GIFs from an MRI brain image
BSD 3-Clause "New" or "Revised" License
118 stars 31 forks source link

changes to the requirements and the README files #2

Closed ilkayisik closed 6 years ago

ilkayisik commented 6 years ago

Hi Michael! Cool repo! When I try to use it I realised the requirement file is downloading the older versions of packages uninstalling the new versions. I changed the equal signs to greater equals and tested it and make sure that it works this way as well. Also made a small change to the readme file.

miykael commented 6 years ago

Hey @ilkayisik - thank you for the changes to the readme and also catching the requirements issues. But as @ofgulban created the requirements file, I let him decide if we should accept your changes ;-)

ofgulban commented 6 years ago

I think it makes sense. Might create issues in the future due to changes in dependencies but I think it is better than causing downgrade of libraries for unsuspecting users :)

miykael commented 6 years ago

Hehe. Perfect! We could setup some test scripts, but I'm not sure if it is necessary for a project like this.

Will merge.