Replicating inputs for VR and PC

miyosuda / unreal

Reinforcement learning with unsupervised auxiliary tasks

Other

416 stars 131 forks source link

Replicating inputs for VR and PC #18

Closed pisiiki closed 6 years ago

pisiiki commented 6 years ago

Hello Miyosuda, I have observed that you are replicating the input of the base network for PC and VR. Replicating the conv layers and reusing kernels/pars. Are you sure this is required? To my understanding TF should be able to compute PC/VR by just reusing self.base_rnn_outputs. It should only process the required operations to get the requested data.

Regards and thanks for sharing your code.

miyosuda commented 6 years ago

Ah, That's right. I'll refactor it. Thanks.