Closed not-my-profile closed 2 years ago
Hi @not-my-profile, thanks for your PR, it looks promising. Could you please split it to 2 separate PRs though? 1 for the refactoring stuff and (possibly later, after the 1st gets merged) 1 for the feature extension of HTMLRenderer? So that it is easier to focus discussion around them. I would have some questions and suggestions before doing a merge, so that we can cover all those "tiny details" which in my opinion are important though...
Or, as I can imagine there would be quite an overhead of Git branching etc. in this case, we could try to discuss it all-in-one here if you want to.
No worries I dropped the third commit from this PR. I'll open a new PR for it once this one is merged.
Once we tune this, we should better apply this to all other renderers to have some consistency, right? That will be quite a job... :)
Thank you!
BaseRenderer
so it's easier to understand.If you like these changes, please merge them without squashing. If you have any questions, I'm happy to answer them.