search

miyuchina / mistletoe

A fast, extensible and spec-compliant Markdown parser in pure Python.
MIT License
811 stars 113 forks source link

Fix for #132, Blocks in between footlink definitions are skipped when parsing #160

Closed anderskaplan closed 1 year ago

anderskaplan commented 2 years ago

Also fixes failing test case 201 in the CommonMark 0.30 test suite.

The fix was done in two steps. Please see commit messages for more details.

pbodnar commented 1 year ago

@anderskaplan, thank you, this is a little bit bigger change to review, I will try to check it out soon, the test cases look promising...

anderskaplan commented 1 year ago

There, I think this is good to go now.

Sorry for bringing you so much review work @pbodnar 😄

pbodnar commented 1 year ago

@anderskaplan, I think everything is resolved now. :) So can you please squash the latest commits before I finally merge this? Alternatively, I could squash all into a single commit, but I guess it is better to keep the 2 fixes in separate commits?

anderskaplan commented 1 year ago

Done -- I've squashed all the small updates into the second commit.

pbodnar commented 1 year ago

Perfect, thank you once again. :)