search

miyucomics / hexical

A Hexcasting addon with various fun and convenient features!
https://miyucomics.github.io/hexical/
MIT License
1 stars 4 forks source link

Hexgloop's mind jars have no compat with Make Genie spell #11

Closed candyCalc closed 3 months ago

candyCalc commented 4 months ago

Using a Hexgloop Mind in a Jar instead of a villager in the Make Genie spell returns this error. image

Reproduction:

  1. Flay a journeyman or higher villager into a Flayer's Pedestal with an Empty Jar on it.
  2. Add the resulting Mind in Jar item entity to the stack
  3. Add the media item entity to the stack
  4. Hold an empty Hand Genie Lamp in the offhand
  5. Cast Make Genie

Expected result:  Mind in a Jar turns into an Empty Jar and the genie lamp's media battery is set.

Actual result:  Sends the error message "Make Genie expected a villager at index 1 of the stack, but got Mind in a Jar" in chat.

Issue on Hexgloop's github: https://github.com/SamsTheNerd/HexGloop/issues/66

miyucomics commented 3 months ago

After some recent changes to how the spell works and its lore to be more useful, I don't think compatibility with minds in jars is thematically appropriate so I'll close this issue.