Closed jabley closed 7 years ago
OK, so it's not as straightforward as I'd hoped. Would you be interested in this change if I can get it working?
I have the tests passing, but I'm not sure what I've done is correct. The ruby issue that introduced rb_thread_call_without_gvl
talks about it being in internal.h
and attempts to use it cause a compiler warning.
I have the tests passing, but I'm not sure what I've done is correct. The ruby issue that introduced rb_thread_call_without_gvl talks about it being in internal.h and attempts to use it cause a compiler warning.
Oh, I'm don't know too. It scary...
I want do not give without_gvl
feature to Ruby v1.9. Because, 1.9 is EOL (as you know) so if strange behavier (or uncaught bug) was found anyone can not fix it.
So, I want to safty. What do you think?
I think not supporting 1.9 is a reasonable position, since it's been EOL for a number of years. People that still have to use 1.9 should be encouraged to upgrade.
Ah, sorry for Misleading response.
I want to support 1.9 as possible.
But, I wantn't to introduce without_gvl
function in 1.9.
How about this? https://github.com/jabley/brotli/pull/1
Despite 1.9 being EOL, some people still need it. This changes adds support for that. The main issue was dir is a 2.x feature.