search

miyucy / brotli

MIT License
59 stars 14 forks source link

Always use the object extension in rbconfig in `extconf.rb`. #29

Closed aardvark179 closed 5 years ago

aardvark179 commented 5 years ago

This is half of the fix for a problem with building Brotli on TruffleRuby (https://github.com/oracle/truffleruby/issues/1638). We currently compile C extensions to llvm bitcode, and store that in .bc files, so our make files don't contain correct rules for building .o files.

This patch changes extconf.rb to use the 'OBJEXT' entry in rbconfig to avoid assuming the wrong extensions.

The other half of the fix is in TruffleRuby itself and I'm putting it through our CI at the moment.

miyucy commented 5 years ago

thank you awesome.