search

mizzao / meteor-bootstrap-3

Bootstrap 3 package for meteor
37 stars 10 forks source link

bootstrap-theme.css #1

Open richardwo opened 9 years ago

richardwo commented 9 years ago

bootstrap-theme.css is included is included in the css folder, but the CSS that Meteor generates doesn't include the theme.

mizzao commented 9 years ago

Yeah, that file is not added in https://github.com/mizzao/meteor-bootstrap-3/blob/master/package.js.

What is it supposed to do? I think you are free to add your own theme in your app by copying that file or generating a similar one, but I'm not sure if we want to force it on people in this package. It's a much smaller set of CSS than the main bootstrap CSS, and can be used to configure specific styling.

richardwo commented 9 years ago

The theme enhances the base css to include gradients on buttons and other components. Sorry - got confused because the file was in your repo - you are right not to force it on people. I'll just copy the bootstrap-theme.css file into my site folder and Meteor should do the rest. Thanks.

----- Original Message ----- From: "mizzao/meteor-bootstrap-3" To:"mizzao/meteor-bootstrap-3" Cc:"Richard Willis-Owen" Sent:Wed, 10 Sep 2014 08:32:48 -0700 Subject:Re: [meteor-bootstrap-3] bootstrap-theme.css (#1)

Yeah, that file is not added in

https://github.com/mizzao/meteor-bootstrap-3/blob/master/package.js [1] 

What is it supposed to do? I think you are free to add your own theme

in your app by copying that file or generating a similar one, but I'm not sure if we want to force it on people in this package. It's a much smaller set of CSS than the main bootstrap CSS, and can be used to configure specific styling. 

—

Reply to this email directly or view it on GitHub [2].

Links:

[1] https://github.com/mizzao/meteor-bootstrap-3/blob/master/package.js [2] https://github.com/mizzao/meteor-bootstrap-3/issues/1#issuecomment-55133473

mizzao commented 9 years ago

If this is a standard theme, happy to include it - otherwise, if it's something that each user downloads a custom version of, I'll leave it out. Could you point me to some docs on this?

simison commented 9 years ago

Theme is optional and it shouldn't be included by default in this kind of package.

One day when Meteor packages will be actually smart, we could have opt-in conditional to include it.

See mentions to it at http://getbootstrap.com/getting-started/