search

mizzao / meteor-bootstrap-3

Bootstrap 3 package for meteor
37 stars 10 forks source link

Direct integration, similar to d3, with tests #14

Closed dandv closed 9 years ago

dandv commented 9 years ago

Since you've been shepherding this for quite a while, might you take a look at my stab at a direct integration?

https://github.com/dandv/bootstrap/compare/meteor-integration

Tests run mostly ok, though I'm not sure why only some JS works (see the README).

Would be great if we could get the Bootstrap folks to pull in a solid PR.

mizzao commented 9 years ago

I'm happy to do this and reduce the maintaining load. However, I recently took this over from @yasinuslu and I'm definitely not as familiar with hooking into other packages' build process like you - so you should feel free to take a stab if you're in the mood.

I think this entire process would be much better served with having package renaming, including author/organization - that would streamline the migration a lot better and maintain continuity for existing installs. @ekatek, any updates on when that will be possible?

dandv commented 9 years ago

In the meantime I've hooked into Bootstrap's Gruntfile so the maintenance load could be effectively zero.

We're live at http://atmospherejs.com/twbs/bootstrap

Waiting for any final feedback/thoughts before submitting the PR.

dandv commented 9 years ago

Engaged with the Bootstrap team.

mizzao commented 9 years ago

Thanks for your work on this. I've been busy with some other stuff lately but will hopefully have a chance to pitch in over the holidays.

mizzao commented 9 years ago

Hey @dandv, is it safe to set this package as unmigrated now and recommend that people switch to twbs:bootstrap instead?

dandv commented 9 years ago

Yes, I do believe so. I've battle-tested it from apps and other packages, e.g. @FezVrasta's Material Design Theme, and it's been through several rounds of feedback from the Bootstrap folks.

mizzao commented 9 years ago

OK, unmigrated and README updated. Good luck to twbs:bootstrap, you should see a ton of users switch over soon.

dandv commented 9 years ago

:bow: & :+1:

https://atmospherejs.com/?q=bootstrap still shows it though?

Maybe related to https://github.com/percolatestudio/atmosphere/issues/320 ?

mizzao commented 9 years ago

I don't know if atmosphere looks for unmigrated. I'd be surprised if it does.

dandv commented 9 years ago

Umigrated packages should not get auto-flagged and not show up in search results.. CC @tmeasday, @dominicnguyen.

tmeasday commented 9 years ago

Looks good now, no?