mizzao / meteor-sharejs

Meteor smart package for transparently adding ShareJS editors to an app
MIT License
225 stars 53 forks source link

Support for Meteor 1.1.0+? #52

Closed archonic closed 8 years ago

archonic commented 8 years ago

I'm running 1.1.0.3 and I'm just getting a disabled textarea with "Loading..." and no errors.

bluepuma77 commented 8 years ago

Same for me, the latest versions of meteor (Meteor 1.1.0.3) and meteor-sharejs (mizzao:sharejs added, version 0.7.4) do not produce the expected functionality, only a textbox with "Loading...".

I created a new meteor app, ran meteor add mizzao:sharejs and added a simple {{> sharejsText docid=docid id="editor"}} in the main HTML file BODY. The textbox only shows "loading", no client or server debug or error output.

meteor-sharejs

Then I installed mizzao:sharejs-ace (mizzao:sharejs-ace added, version 1.1.8_1) on top of this, but {{> sharejsAce docid=docid id="editor"}} doesn't even show a textarea, even though the HTML is present in the web page. Same for mizzao:sharejs-codemirror.

meteor-sharejs-ace

mizzao commented 8 years ago

@bluepuma77 you need to set a size on #editor if you are using Ace.

More generally, I don't think there is any problem with 1.1.0+. I just updated the demo to 1.1.0.3 and also deployed it to http://documents.meteor.com/ , and it works fine. I'm pretty sure this is just user error and you guys need to do a little more work to figure out what is broken.