mizzao / meteor-sharejs

Meteor smart package for transparently adding ShareJS editors to an app
MIT License
225 stars 53 forks source link

in Meteor 1.3 unexpected token < error at loading themes and modes #66

Closed jortegamo closed 8 years ago

jortegamo commented 8 years ago

Hi! I'm using this package for a year. Now it not work fine!. My code:


var editor = ace.edit('editor'); editor.setTheme('ace/theme/monokai'); editor.getSession().setMode('ace/mode/javascript');

At that moment console shows: unexpected token <: theme-monokai.js cannot read property cssClass of undefined: share-ace.js unexpected token <: mode-javascript.js

Thanks!

DavidSichau commented 8 years ago

This is due to the fact that ace is not loaded in meteor 1.3 previously to the ace.js file required by sharejs. See my pull request to get it working with meteor 1.3.

mizzao commented 8 years ago

See #67.

jortegamo commented 8 years ago

Ok nice!. Now How I can incorporate changes into my project?

DavidSichau commented 8 years ago

@jortegamo You can clone my fork and use it as an local package or wait until the pull request is tested and accepted. by mizzao.

jortegamo commented 8 years ago

Thanks! Its my first time with a pull request.