Closed DavidSichau closed 8 years ago
@mizzao Any Chance that this gets merged? At the moment this is blocking us to update the our application to meteor 1.3. And I want to avoid to publish the package independently.
Awaiting the merge so I can upgrade to Meteor 1.3
Sorry guys, I'm traveling and will have to review this later.
Hi @mizzao would it be possible to merge this at all? Of course I understand if you don't have time to check it, but many people would really benefit from being able to upgrade to 1.3 and still use this package.
Deleted as mizzao:sharejs packages where updated.
@DavidSichau, would you like to be added to the publishers list for this package and just push it out directly under mizzao:sharejs
, or do you want to maintain your own fork?
@mizzao I think publishing under your name makes sense when the changes are added to this repo. Otherwise another name would be better to avoid a difference in the source code and the published packages.
@DavidSichau - I'm asking if you want push access to this repo and publishing rights to the Meteor package name :)
It's better to have someone actively using this maintaining it than someone who isn't!
@mizzao That would be great. I will try to maintain this package then in the future.
Great. What's your Meteor username? I will add you to this repo and add your Meteor account to the atmosphere package as well.
I'm happy to answer any questions about maintaining the package or other confusing things, if you run into issues.
The meteor username is: davidsichau
I will start to merge my changes tomorrow and publish the compatible version of the package.
Great, davidsichau
can now publish for mizzao:sharejs
, mizzao:sharejs-ace
, and mizzao:sharejs-codemirror
.
@jakubfiala Please use again the mizzao share js packages. I have updated them to the newest version.
that's brilliant, thank you very much @DavidSichau
Now ShareJS Ace works again with meteor 1.3.
Problems
src
folder oface-build
folder should be deleted.Advantages
fixes #65 fixes #55