Use npm dependencies and module system

[DavidSichau]

Sharejs now imports all dependencies as npm dependencies. This avoids the setup of gitsubmodules.

It uses the module system to simplify the handling of the dependencies.

Most of the code was rewritten in plain js with ecmascript.

Discussion:

The following points are no solved to my satisfaction:

• [x] Ace sets as base path the path to an external CDN as I did not figured out a way to points this to the npm module. If anyone has an suggestion please tell me.
• [ ] I still have some global variables which spoil the global namespace. The problem is that ace uses requirejs and this results in some problem in combination with the module system of meteor.
• [x] The authentication. I did not touch this file. As I am not sure if this is actually worth it. At the moment as a token the Meteor.userId is used. I would think of this as a not secret token. Therefore the whole security is flawed. I would suggest to drop the current auth system, as it adds no real security.

[mizzao]

This looks fantastic!

One way to get around the dependency on the external CDN that you outlined is to use addAssets to serve files from the npm module, see

https://github.com/mizzao/meteor-sharejs/blob/749f8135365bb61420b4edd2d17b33f8a5e10eee/sharejs-base/package.js#L23

but you may want to do it programmatically as in

https://github.com/mizzao/meteor-sharejs/blob/749f8135365bb61420b4edd2d17b33f8a5e10eee/sharejs-ace/package.js#L69)

then set this as the basePath on the client. It's going to look very funky, probably packages/mizzao:sharejs/.npm/package/node_modules/ace/... but it'll work.

You get rid of the dependency on the external CDN, but you do have a somewhat brittle implementation (if Meteor changes that directory structure). However, it's worked since 0.8 or whenever I started this, so I think it will be fine.

Awesome that you rewrote in ES6 instead of coffee, and I agree that dropping the auth system is probably fine until you have time to implement a better one. #6 was pretty random anyway.

Let me know when you get this merged; that would probably be a good time for me to put the demo back up on Galaxy.

[DavidSichau]

So we had this code running in our app since 1 month and it seems to be fine.

So I would suggest to merge this pull request even if I still did not found a way to include ace in a clean way.

However we have a breaking change that we now drop the authentication.

[mizzao]

Yeah, feel free to remove the authentication and remove the documentation for it!

Great to hear that you have this working in production. I am very happy to have someone else using and maintaining it!

Did I give you publish permission on Atmosphere for this package?

[DavidSichau]

Yes I have the rights. I will publish it tomorrow afternoon (European).

This is one of our core packages we use, thanks a lot for your efforts to provide this package.