mj2p / psub

CLI Subsonic Client
MIT License
31 stars 6 forks source link

Add checking api version #6

Closed sprnza closed 5 years ago

sprnza commented 5 years ago

In order to support another Subsonic-like severs using older API (Supysonic for example) I added api check mechanism, because older API had another authentication mechanism.

sammoth-ripjar commented 5 years ago

Thank you for this and apologies for being absent for so long. I tested out your fork and the changes seem good. I've not tested on a server with a different API version though so will have to take your word that it works :) My only reservation is that the logic around the artist id has changed. Previously, choosing the default 0 prompted the user to enter a new search term but now the logic is to enter a number higher than the highest search result id. I'm ok with that but the wording of the prompt is now slightly incorrect. I'm going to merge the changes though as I've wanted to use Questionary to display the user choices for a while and this will get me to actually do that.

sprnza commented 5 years ago

Yay! Questionary is a much better option! Thanks!