search

mj2p / psub

CLI Subsonic Client
MIT License
31 stars 6 forks source link

Notifications on song change #9

Closed sprnza closed 2 years ago

sprnza commented 5 years ago

Hi there! Here is my attempt to do notifications on song change. Configurable.

Thanks!

inuitwallet commented 5 years ago

Apologies for the delay again. I've been changing jobs. I've tried this out and it works fine on my Ubuntu Machines. Doesn't work at all on Mac though as it seem you need different notification libraries entirely. I don't have a Mac any more (since the job change) so I'm half thinking of just merging and making a not of that in the README. Wondered if you have any thoughts on making this functionality an optional extra instead? Perhaps pSub needs a plugin feature?

sprnza commented 5 years ago

Yep, definitly must be configurable. I'll update the PR when I get some spare time.

sammoth-ovo commented 5 years ago

I had a go at making notifications a separate module, I hope you don't mind? I've put the code in a separate branch for now https://github.com/mj2p/psub/tree/notifications I'd like to find a machine that doesn't have the dependencies installed so I can see if the separation works then.

sprnza commented 5 years ago

No worries! Looks great, I'll test it once I get a chance. Tough times at work.

mj2p commented 2 years ago

notifications on song change are now in master branch. closing this PR.