search

mjackson / expect

Write better assertions
MIT License
2.29k stars 117 forks source link

`expect` on npm is now mapped to `facebook/jest` not this project #228

Closed anglinb closed 7 years ago

anglinb commented 7 years ago

tl;dr Following the installation instructions in the README.md actually installs facebook/jest, not this project.

Explanation

👋 I recently saw greenkeeper create a PR on a project I contribute to asking us to update our expect dependency to 21.0.0. After investigating, expect on npm is now at version 21.0.0 and the link to the source is github.com/facebook/jest, not this project.

@cpojer I saw that you were the last to publish to https://www.npmjs.com/package/expect, did you mean to publish jest instead of this project under the expect name?

If so, I think the README.md Installation section should get changed to match wherever this project is listed on NPM.

Confirming I wasn't crazy

I double checked I wasn't crazy by running npm install --save expect as the instructions say to do with a fresh node project and I end up with jest installed not this project:

banners_and_alerts_and_1__brian_brians-macbook-pro____files_endavors_test__zsh_

Please let me know if I can help sort this out. Thanks 🙌

/cc @mjackson @cpojer

cpojer commented 7 years ago

See https://github.com/mjackson/expect/issues/226 and https://github.com/mjackson/expect/pull/227

anglinb commented 7 years ago

Missed those--thanks.