mjackson / expect

Write better assertions
MIT License
2.29k stars 117 forks source link

State of the library #234

Closed alex-dixon closed 6 years ago

alex-dixon commented 6 years ago

Sorry to make an issue out of this, but I'm confused. I see expect has been donated to Facebook and future development will happen within Jest but I'm not clear on whether that means no maintenance or changes of any kind will happen in this repo and the npm package.

If not, could this repo to be maintained or developed separately for those of us who prefer it to Jest's version of expect?

ljharb commented 6 years ago

I'd be happy to backport nonbreaking changes to v1, but I no longer have publish rights to expect.

@mjackson or @cpojer or the other folks here would have to be willing to do it, and I suspect none of them have interest in it.

If they'd be happy with me doing backports (using safe-publish-latest to ensure no "latest" mistakes), they're welcome to add me back as an owner on npm - but short of that, there's not likely to be any further development.

cpojer commented 6 years ago

@ljharb added you back to the npm project :)

ljharb commented 6 years ago

Thanks!

In that case, @alex-dixon: I'll update the readme, and ensure the appropriate protections are in place, and then I'll close this issue again - at which point, enhancements to v1 will be welcome.

alex-dixon commented 6 years ago

@ljharb Thanks! I think this is the best assertion library for Javascript and it seems like Jest has removed some of its features, like .toBeA. If I use the latest npm version, can I expect (har) all methods that are documented in the README?

inca commented 6 years ago

Same with .toExist — it's not a function anymore 😕

Since this module is used by so many people, can we please at least have some sort of public announcement with plans for future development?

ljharb commented 6 years ago

@inca v21+ is part of jest; https://github.com/mjackson/expect/issues/234#issuecomment-336207615 is the announcement for further development here for versions < 21.

I haven't yet had time to update the readme, but when I do, I'll close this issue.

alex-dixon commented 6 years ago

So npm install expect @ 0.20.0 should work for expect standalone?

Is there a way forward for development and maintenance? If so curious about the version scheme.

ljharb commented 6 years ago

@alex-dixon v21+ is maintained by the jest team; I will continue to maintain v1. I'm unlikely to accept any breaking changes; I'm going to be very limited in the additive changes I expect; and I'm going to put tooling in place to ensure that I only ever publish pre-v21 versions under an npm tag that isn't "latest", so only people who have explicitly depended on pre-v21 versions see any further publishes (see https://github.com/mjackson/expect/issues/234#issuecomment-336204361)

mjackson commented 6 years ago

Thanks for taking the baton here, @ljharb. I'm done maintaining my own assertion library! 😅