search

mjackson / rack-accept

HTTP Accept* for Ruby/Rack
http://mjackson.github.com/rack-accept
47 stars 16 forks source link

incorrect parsing of media-ranges etc #4

Closed SSDany closed 14 years ago

SSDany commented 14 years ago

http://github.com/mjijackson/rack-accept/issues/closed#issue/3

Did you read the ABNF in RFC2616, section 14.1? First example shows you not parameter, but accept-extension.

Qvalue in the second example is malformed, really. Simply because this example demonstrates that your code does not check qvalues against corresponding ABNF.

Please, feel free to close this issue if rack-accept is not able to hahdle malformed data (and inform user about it by raising an exception and so on) and/or is not able to parse HTTP_ACCEPT header in compliance with ABNF.

mjackson commented 14 years ago

Fixed in cb7ea6cc7fa99abaf6976253610d8fbe5672d9af