Suggested improvements - Githubissues

mjacqu / glenglat

Global Englacial Temperature database

Creative Commons Attribution 4.0 International

2 stars 0 forks source link

Suggested improvements #2

Closed ezwelty closed 1 year ago

ezwelty commented 1 year ago

Here are my suggestions for (what I believe are) improvements to the data structure or packaging based on the state of the data package once https://github.com/mjacqu/glenglat/pull/1 is merged.

General

[x] #25
[x] Clarify the license: CC-BY-4.0 (in metadata) or MIT (LICENSE)
[x] #4
[x] #26
[x] #27
[x] #13
[x] #17
[x] #22
[ ] List any data sources published online in the sources property (see https://specs.frictionlessdata.io/data-package/#sources).
[x] #29
[x] #14
[x] #23
[x] #24

`sources`

[x] ~~Add required constraint to included and fill missing values as needed.~~ (included has been removed)
[x] #5
[x] #6
[x] #7

`boreholes`

[x] #8
[x] #9
[x] #21
[x] #12
[x] #20
[x] #10
[x] #11
[x] #16
[x] #15

`temperatures`

[x] Drop column to_bottom, since the information is already provided (in a more normalized fashion) in boreholes.to_bottom.
[x] #28
[x] #18
[x] #19

Output

[x] Transform all borehole coordinates to WGS 84 latitude, longitude (EPSG:4326).
[x] Include identifier (code, path, URL) of plot digitization, if these are ultimately included.
[ ] Generate documentation from datapackage.yaml (see frictionless.Package.to_markdown() or custom Jinja templates like https://gitlab.com/wgms/glathida/-/blob/main/scripts/readme.md.jinja).