oscfdezdz
commented
6 months ago Thanks for the heads up! Does the following patch together with your patches fix it?
From 1fe44e88a343d347f9703a4ee1086bbc0ebb50b7 Mon Sep 17 00:00:00 2001
From: oscfdezdz <42654671+oscfdezdz@users.noreply.github.com>
Date: Fri, 17 May 2024 01:20:57 +0200
Subject: [PATCH] Fix some warnings
---
src/exm-detail-view.c | 4 ++--
src/exm-window.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/exm-detail-view.c b/src/exm-detail-view.c
index f91bb1a..072513e 100644
--- a/src/exm-detail-view.c
+++ b/src/exm-detail-view.c
@@ -595,8 +595,8 @@ exm_detail_view_class_init (ExmDetailViewClass *klass)
gtk_widget_class_bind_template_callback (widget_class, breakpoint_unapply_cb);
gtk_widget_class_bind_template_callback (widget_class, screenshot_view_cb);
- gtk_widget_class_install_action (widget_class, "detail.open-extensions", NULL, open_link);
- gtk_widget_class_install_action (widget_class, "detail.open-homepage", NULL, open_link);
+ gtk_widget_class_install_action (widget_class, "detail.open-extensions", NULL, (GtkWidgetActionActivateFunc) open_link);
+ gtk_widget_class_install_action (widget_class, "detail.open-homepage", NULL, (GtkWidgetActionActivateFunc) open_link);
}
static void
diff --git a/src/exm-window.c b/src/exm-window.c
index 472c199..ade4ffd 100644
--- a/src/exm-window.c
+++ b/src/exm-window.c
@@ -404,7 +404,7 @@ exm_window_init (ExmWindow *self)
}
self->manager = exm_manager_new ();
- g_signal_connect (self->manager, "error-occurred", on_error, self);
+ g_signal_connect (self->manager, "error-occurred", G_CALLBACK (on_error), self);
g_object_set (self->installed_page, "manager", self->manager, NULL);
g_object_set (self->browse_page, "manager", self->manager, NULL);
--
2.45.0
bill88t
Describe the bug Hello there, I am the current maintainer of the AUR package of this project. As of a few days ago, new stuff landed on Arch with breaking api changes.
Here is what the current build output would look like with only #638 patched in on top of
tag/v0.5.1:This lommg error list might seem scary, but don't worry I already wasted my time on it. There are only 4 types of errors, missing C handlers, one cast of interger into pointer, NULL returns and open_link arguments.
The cast just needs a
&and it's fixed. I don't know how can I make this patch work across old and new versions, so.. just letting you know I guess..The return errors are because of the use of
g_return_if_failinstead ofg_return_val_if_fail. I created some patches solving this downsteam, I will PR them in a bit.The C handler and open_link errors I don't know about. I know C (and embedded C at that) but I am not very aquainted with all the gnome stuff.
System Information:
Additional context The AUR repo, including the PKGBUILD are available in
ssh://aur@aur.archlinux.org/extension-manager.gitif you feel like viewing them.