search

mjakubowski84 / parquet4s

Read and write Parquet in Scala. Use Scala classes as schema. No need to start a cluster.
https://mjakubowski84.github.io/parquet4s/
MIT License
283 stars 65 forks source link

ParquetSchemaResolver test fails on recent JVMs #328

Closed i10416 closed 10 months ago

i10416 commented 11 months ago

A test ParquetSchemaResolver should use default schema name when processing a class that JVM treats as malformed fails when it runs on recent JDKs.

ParquetSchemaResolver should use default schema name when processing a class that JVM treats as malformed 
- "[com.github.mjakubowski84.parquet4s.ParquetSchemaResolverSpec.Malformed$.Clazz]" was not equal to "[parquet4s_schema]"

Recent JVM does not regard the given class as malformed here https://github.com/mjakubowski84/parquet4s/blob/6cf658a112353b2ef4accfec11da00b7e03a8b75/core/src/main/scala-2.12/com/github/mjakubowski84/parquet4s/ParquetSchemaResolver.scala#L93.

mjakubowski84 commented 10 months ago

Yes, this test is for JDK8. Parquet4s is built by JDK8 (yes, lots of people still use JDK8), so the test checks this case. Check https://github.com/mjakubowski84/parquet4s/blob/master/.java-version