mjambon / dune-deps

Show the internal dependencies in your OCaml/Reason/Dune project
BSD 3-Clause "New" or "Revised" License
58 stars 6 forks source link

Esy issue #23

Open anchpop opened 3 years ago

anchpop commented 3 years ago

When adding @opam/dune-deps to my package.json devDependencies, I get this error:

info esy 0.6.11 (using package.json)
info building @opam/dune-deps@opam:1.3.0@53c75e19
error: build failed with exit code: 125
  build log:
    # esy-build-package: building: @opam/dune-deps@opam:1.3.0
    # esy-build-package: pwd: /home/node/.esy/3/b/opam__s__dune_deps-opam__c__1.3.0-42a94736
    esy-build-package: internal error, uncaught exception:
                       Stack overflow

  building @opam/dune-deps@opam:1.3.0
esy: exiting due to errors above

This is probably an esy bug, but I thought I'd let you know about it too

melwyn95 commented 3 years ago

I vaguely got the issue the build path for dune-deps on my machine is ~/.esy/3/b/opamsdune_deps-opamc1.3.0-1c308da1 when I cd into that directory and run tree . the tree keeps on running infinitely maybe some cycle via smylinks (not sure) so in esy there is this link https://github.com/esy/esy/blob/master/esy-build-package/Build.re#L423 which tries to delete the build path & goes in cycle

in the test directory there are two symlinks that are forming a cycle link-to-foo -> https://github.com/mjambon/dune-deps/blob/master/test/proj/link-to-foo link-to-parent -> https://github.com/mjambon/dune-deps/blob/master/test/proj/foo/link-to-parent

will look into this issue in detail & get back

anchpop commented 3 years ago

Thanks for looking into it, I'd really like to use this in my project