search

mjambon / tophide

Hide values starting with _ in the ocaml toplevel
http://martin.jambon.free.fr/ocaml.html#tophide
Other
4 stars 3 forks source link

OCaml 5.3 compatibility #5

Open phongulus opened 3 days ago

phongulus commented 3 days ago

Fix for OCaml 5.3, https://github.com/mjambon/tophide/issues/4

mjambon commented 3 days ago

You might want to add a note about Format_doc and update the opam file with the dependency. I'm assuming it depends on the package format-doc.

mjambon commented 3 days ago

Feel free to merge anyway. Let me know if you want maintainer rights.

phongulus commented 3 days ago

it depends on the package format-doc.

No, Format_doc is from OCaml 5.3, here: https://github.com/ocaml/ocaml/blob/70691e6d46c155f66bb5afb07357e01a48d33e59/utils/format_doc.mli

so there are no extra dependencies ☺️ . But we would need to put "ocaml" {>= "5.3"} & {< "5.4"} in the opam file.

@mjambon can you help merge? Then maybe @kit-ty-kate can do the release? Or I can try doing it later.

kit-ty-kate commented 2 days ago

Then maybe @kit-ty-kate can do the release?

I can't help doing the actual release (tagging) but i can help publishing to opam-repository if you want

phongulus commented 2 days ago

i can help publishing to opam-repository if you want

Sorry, bad word choice, that's what I meant by "release" earlier 😅. Then for the tagging we'd need @mjambon's help.