search

mjaric / ng2-heremaps

Here maps for Angular 2, 4, 5
MIT License
6 stars 12 forks source link

Return mapEvents and behavior when creating map #9

Closed michael-mader closed 4 years ago

michael-mader commented 5 years ago

(needed for advanced dragging features)

mjaric commented 5 years ago

Hi @Fender123 is this PR complete?

michael-mader commented 5 years ago

Yes. What do you think is missing?

Milan Jaric notifications@github.com schrieb am Di., 25. Juni 2019, 00:00:

Hi @Fender123 https://github.com/Fender123 is this PR complete?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mjaric/ng2-heremaps/pull/9?email_source=notifications&email_token=AAJRWDHP72I7NKDM672UV3TP4E7XBA5CNFSM4H23HH3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYOLMMA#issuecomment-505198128, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJRWDHB5TPDXB2OGFNSHVTP4E7XBANCNFSM4H23HH3A .

jedsmith13 commented 4 years ago

@Fender123 I think the question is what does adding the mapEvents and behavior do when you aren't exposing an input or output for the component to access them? Are you accessing them through a ViewChild reference or some other way?

michael-mader commented 4 years ago

@jedsmith13 yes you are right. The access is done via ViewChild reference. Exactly the same way ui is accessed.

jedsmith13 commented 4 years ago

I will go ahead and merge this it, though in the future maybe we should add some of the functionality that you would need these for to the code directly, I actually have a couple of things I am wanting to add that I will need the behavior for.