search

mjarkk / general_programming_language

A temporarly repo for an idea to create a programming language that can be compiled into other languages
MIT License
1 stars 0 forks source link

Fix single statement only bug #8

Closed TheOtterlord closed 4 years ago

TheOtterlord commented 4 years ago

This fixes the problem where only the first statement would be parsed. It does not yet fix tests, but after testing with example.gpl everything seems to work. If you have any suggestions for fixing the tests, please let me know.

mjarkk commented 4 years ago

It rather broke the tests again :) but now we at least know the places where there is still work todo

TheOtterlord commented 4 years ago

Yes, we do need to look at the tests. I will try to find out what is happening with each failing test and attempt to add some validation.

TheOtterlord commented 4 years ago

By the way, it seems that test_function_empty if failing because a tab is treated as an unexpected character, after the function. I am not sure why this happens, but it may explain why some of the other tests are failing.

TheOtterlord commented 4 years ago

Fixed by allowing for whitespace

TheOtterlord commented 4 years ago

All merged and working

mjarkk commented 4 years ago

I've merged it! because the last comment is not really a bit issue.

TheOtterlord commented 4 years ago

Sorry, didn't get a notification about that last one for some reason. I'll commit the change to my fork now, but will add more stuff before merging it, as it is a small thing.

mjarkk commented 4 years ago

nonononono i already fixed it myself :)
This is a kinda annoying bug so i couldn't wait for merging it in

TheOtterlord commented 4 years ago

Ok, cool 😄